LGTM.
http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc File src/lithium-allocator.cc (right): http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc#newcode300 src/lithium-allocator.cc:300: // If split position coincides with the beginning of use interval "the split position"..."a use interval" :) http://codereview.chromium.org/5898001/diff/1/src/lithium-allocator.cc#newcode331 src/lithium-allocator.cc:331: while (use_after != NULL && use_after->pos().Value() < position.Value()) { Maybe this case needs a short comment too, something like "We are splitting at the start of an interval. The use position at the start of the interval belongs after the split." http://codereview.chromium.org/5898001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
