Two comments you should address, otherwise LGTM.
http://codereview.chromium.org/5971003/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/5971003/diff/1/src/hydrogen-instructions.h#newcode2552 src/hydrogen-instructions.h:2552: HLoadNamedField(HValue* object, bool is_in_object, int offset) I'd rather pass is_polymorphic to the constructor and get rid of set_is_polymorphic completely. The way it's written, it's effectively a default parameter value (slightly worse because it's artificially mutable), and more verbose too. http://codereview.chromium.org/5971003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/5971003/diff/1/src/hydrogen.cc#newcode1460 src/hydrogen.cc:1460: if (instr->IsLoadNamedField() && You could accomplish essentially the same thing by not setting kUseGVN for polymorphic named loads. That seems nicer than a special case in the implementation. We would use the ability to share them via GVN, but I don't think we can do that in practice anyway. http://codereview.chromium.org/5971003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
