LGTM
http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc#newcode2481 src/ia32/code-stubs-ia32.cc:2481: // UNTAGGED cast: cast->case. http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc#newcode2601 src/ia32/code-stubs-ia32.cc:2601: } else { // UNTAGGED. Do we need to allocate a number in the UNTAGGED case? http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc#newcode2620 src/ia32/code-stubs-ia32.cc:2620: __ bind(&skip_cache); Does this mean that we don't cache the result in the untagged case? http://codereview.chromium.org/5996002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
