LGTM

http://codereview.chromium.org/6084003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6084003/diff/1/src/hydrogen.cc#newcode5146
src/hydrogen.cc:5146: // BAILOUT("boo");
Strange comment.

http://codereview.chromium.org/6084003/diff/1/src/hydrogen.cc#newcode5152
src/hydrogen.cc:5152: for (int i = 0; i < argc; i++) { arguments[i] =
Pop(); }
We normally split for statements across three lines.

http://codereview.chromium.org/6084003/diff/1/src/hydrogen.cc#newcode5154
src/hydrogen.cc:5154: for (int i = argc - 1; i >= 0; i--) {
Push(arguments[i]); }
Ditto.

http://codereview.chromium.org/6084003/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to