Good fix. LGTM.
http://codereview.chromium.org/6072004/diff/1/src/heap-inl.h File src/heap-inl.h (right): http://codereview.chromium.org/6072004/diff/1/src/heap-inl.h#newcode45 src/heap-inl.h:45: // Check for ascii first since this is the common case. ASCII is an acronym, even though we might not respect that in function names. More instances below. http://codereview.chromium.org/6072004/diff/1/src/heap-inl.h#newcode47 src/heap-inl.h:47: if (static_cast<uc16>(str[i]) > String::kMaxAsciiCharCode) { Just cast to uint8_t, and compare to String:kMaxAsciiCharCodeU. It will allow the compiler to just check the sign bit. http://codereview.chromium.org/6072004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
