Reviewers: Søren Gjesse,
Description:
Added context sensitive prompt for remote debugger. It now shows "> "
when the debuggee is running, and "dbg> " when the debuggee is stopped.
Please review this at http://codereview.chromium.org/5966004/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/d8-debug.cc
Index: src/d8-debug.cc
===================================================================
--- src/d8-debug.cc (revision 6115)
+++ src/d8-debug.cc (working copy)
@@ -34,12 +34,21 @@
namespace v8 {
-void PrintPrompt() {
- printf("dbg> ");
+static bool was_running = true;
+
+void PrintPrompt(bool is_running) {
+ const char* prompt = is_running? "> " : "dbg> ";
+ was_running = is_running;
+ printf("%s", prompt);
fflush(stdout);
}
+void PrintPrompt() {
+ PrintPrompt(was_running);
+}
+
+
void HandleDebugEvent(DebugEvent event,
Handle<Object> exec_state,
Handle<Object> event_data,
@@ -91,7 +100,7 @@
bool running = false;
while (!running) {
char command[kBufferSize];
- PrintPrompt();
+ PrintPrompt(running);
char* str = fgets(command, kBufferSize, stdin);
if (str == NULL) break;
@@ -284,7 +293,9 @@
} else {
printf("???\n");
}
- PrintPrompt();
+
+ bool is_running =
details->Get(String::New("running"))->ToBoolean()->Value();
+ PrintPrompt(is_running);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
