LGTM
http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newcode2897 src/arm/code-stubs-arm.cc:2897: // object in r0 (or at sp+1*ptrsz) and function in ptrsz => kPointerSize ? http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newcode2925 src/arm/code-stubs-arm.cc:2925: __ LoadRoot(object, Heap::kInstanceofCacheAnswerRootIndex); r0 instead of object to reduce confusion http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newcode2991 src/arm/code-stubs-arm.cc:2991: __ push(r0); __ Push(r0, r1); ? http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#newcode1340 src/arm/lithium-codegen-arm.cc:1340: ASSERT(ToRegister(instr->left()).is(r0)); // object is in r0 // Object is in r0. something like that http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#newcode1341 src/arm/lithium-codegen-arm.cc:1341: ASSERT(ToRegister(instr->right()).is(r1)); // function is in r1 ditto http://codereview.chromium.org/6055006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
