Can't find this issue in the code review tool. Could you upload again? Thanks, -- Mads
On Wed, Dec 22, 2010 at 6:44 PM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Message: > Adding objects-printer.cc to Xcode project. > > Description: > Adding objects-printer.cc to Xcode v8 project. > > > BUG= > TEST= > > Please review this at http://codereview.chromium.org/5969006/ > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge > > Affected files: > M tools/v8.xcodeproj/project.pbxproj > > > Index: tools/v8.xcodeproj/project.pbxproj > diff --git a/tools/v8.xcodeproj/project.pbxproj > b/tools/v8.xcodeproj/project.pbxproj > index > 5254c6e665ac0a3635d3e4541b3e96616d6980d3..2bc33d4d7f37f592132f70af49faa5e6b4940a6c > 100644 > --- a/tools/v8.xcodeproj/project.pbxproj > +++ b/tools/v8.xcodeproj/project.pbxproj > @@ -94,6 +94,8 @@ > 8944AD100F1D4D500028D560 /* regexp-stack.cc in Sources */ = > {isa = PBXBuildFile; fileRef = 8944AD0E0F1D4D3A0028D560 /* regexp-stack.cc > */; }; > 8944AD110F1D4D570028D560 /* regexp-stack.cc in Sources */ = > {isa = PBXBuildFile; fileRef = 8944AD0E0F1D4D3A0028D560 /* regexp-stack.cc > */; }; > 894599A30F5D8729008DA8FB /* debug-agent.cc in Sources */ = > {isa = PBXBuildFile; fileRef = 8956B6CD0F5D86570033B5A2 /* debug-agent.cc > */; }; > + 8946827512C26EB700C914BC /* objects-printer.cc in Sources */ > = {isa = PBXBuildFile; fileRef = 8946827412C26EB700C914BC /* > objects-printer.cc */; }; > + 8946827612C26EB700C914BC /* objects-printer.cc in Sources */ > = {isa = PBXBuildFile; fileRef = 8946827412C26EB700C914BC /* > objects-printer.cc */; }; > 89495E480E79FC23001F68C3 /* compilation-cache.cc in Sources > */ = {isa = PBXBuildFile; fileRef = 89495E460E79FC23001F68C3 /* > compilation-cache.cc */; }; > 89495E490E79FC23001F68C3 /* compilation-cache.cc in Sources > */ = {isa = PBXBuildFile; fileRef = 89495E460E79FC23001F68C3 /* > compilation-cache.cc */; }; > 8956B6CF0F5D86730033B5A2 /* debug-agent.cc in Sources */ = > {isa = PBXBuildFile; fileRef = 8956B6CD0F5D86570033B5A2 /* debug-agent.cc > */; }; > @@ -447,6 +449,7 @@ > 893E24DB12B14B9F0083370F /* gc-extension.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name > = "gc-extension.h"; path = "extensions/gc-extension.h"; sourceTree = > "<group>"; }; > 8944AD0E0F1D4D3A0028D560 /* regexp-stack.cc */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = "regexp-stack.cc"; sourceTree = "<group>"; }; > 8944AD0F0F1D4D3A0028D560 /* regexp-stack.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = "regexp-stack.h"; sourceTree = "<group>"; }; > + 8946827412C26EB700C914BC /* objects-printer.cc */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = "objects-printer.cc"; sourceTree = "<group>"; }; > 89471C7F0EB23EE400B6874B /* flag-definitions.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = "flag-definitions.h"; sourceTree = "<group>"; }; > 89495E460E79FC23001F68C3 /* compilation-cache.cc */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = "compilation-cache.cc"; sourceTree = "<group>"; }; > 89495E470E79FC23001F68C3 /* compilation-cache.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = "compilation-cache.h"; sourceTree = "<group>"; }; > @@ -1003,6 +1006,7 @@ > 897FF15F0E719B8F00D62E90 /* natives.h */, > 897FF1600E719B8F00D62E90 /* objects-debug.cc > */, > 897FF1610E719B8F00D62E90 /* objects-inl.h */, > + 8946827412C26EB700C914BC /* > objects-printer.cc */, > C2D1E9711212F27B00187A52 /* > objects-visiting.cc */, > C2D1E9721212F27B00187A52 /* > objects-visiting.h */, > 897FF1620E719B8F00D62E90 /* objects.cc */, > @@ -1595,6 +1599,7 @@ > 893E24D712B14B8A0083370F /* lithium-ia32.cc > in Sources */, > 893E24DC12B14B9F0083370F /* > externalize-string-extension.cc in Sources */, > 893E24DD12B14B9F0083370F /* gc-extension.cc > in Sources */, > + 8946827512C26EB700C914BC /* > objects-printer.cc in Sources */, > ); > runOnlyForDeploymentPostprocessing = 0; > }; > @@ -1750,6 +1755,7 @@ > 893E24CE12B14B520083370F /* > lithium-codegen-arm.cc in Sources */, > 893E24DE12B14B9F0083370F /* > externalize-string-extension.cc in Sources */, > 893E24DF12B14B9F0083370F /* gc-extension.cc > in Sources */, > + 8946827612C26EB700C914BC /* > objects-printer.cc in Sources */, > ); > runOnlyForDeploymentPostprocessing = 0; > }; > @@ -1850,7 +1856,7 @@ > DEBUG, > ENABLE_LOGGING_AND_PROFILING, > V8_ENABLE_CHECKS, > - OBJECT_PRINT, > + OBJECT_PRINT, > ENABLE_VMSTATE_TRACKING, > ); > GCC_SYMBOLS_PRIVATE_EXTERN = YES; > @@ -1915,7 +1921,7 @@ > V8_TARGET_ARCH_IA32, > DEBUG, > V8_ENABLE_CHECKS, > - OBJECT_PRINT, > + OBJECT_PRINT, > ENABLE_DEBUGGER_SUPPORT, > ); > HEADER_SEARCH_PATHS = ../src; > @@ -1978,7 +1984,7 @@ > V8_TARGET_ARCH_IA32, > DEBUG, > V8_ENABLE_CHECKS, > - OBJECT_PRINT, > + OBJECT_PRINT, > ENABLE_DEBUGGER_SUPPORT, > ); > HEADER_SEARCH_PATHS = ../src; > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
