LGTM with comments addressed.
http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode309 src/liveedit.cc:309: TokensCompareInput(Handle<String> s1, int offset1, int len1, Only 2 char indentation of constructor, and align arguments. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode314 src/liveedit.cc:314: int getLength1() { Please use getter name len1, see http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Names#Function_Names. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode317 src/liveedit.cc:317: int getLength2() { Ditto. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode337 src/liveedit.cc:337: public: Only 2 char indentation of constructor. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode432 src/liveedit.cc:432: public: Indentation. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode445 src/liveedit.cc:445: if (char_len1 < CHUNK_LEN_LIMIT && char_len2 < CHUNK_LEN_LIMIT) { Indentation. http://codereview.chromium.org/6017008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
