LGTM. Small comments below.
http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h File src/lithium-allocator.h (right): http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode758 src/lithium-allocator.h:758: class FlexibleBitVector BASE_EMBEDDED { Maybe GrowableBitVector is more descriptive? It never shrinks, does it? http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode762 src/lithium-allocator.h:762: bool Contains(int value) const { Maybe it's too cute, but you could make this class more specialized and have it handle the scaling (storing first_artificial_register_ and subtracting it in the Contains and Add functions). http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode773 src/lithium-allocator.h:773: static const int kInitialLength = 1024; This seems like a big initial length. http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode1010 src/lithium-allocator.h:1010: int first_artificial_register_; I'd be more comfortable with an initial value, even if invalid. http://codereview.chromium.org/6065010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
