LGTM with small comments below.
http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc File src/lithium-allocator.cc (right): http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc#newcode1596 src/lithium-allocator.cc:1596: LUnallocated::cast(summary->Output())->HasFixedPolicy() || You could define a predicate on LUnallocated: bool HasFlexibleRegisterPolicy() { return HasRegisterPolicy() && !HasFixedPolicy(); } And use it (negated) in three places here. http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc#newcode1599 src/lithium-allocator.cc:1599: ASSERT(LUnallocated::cast(summary->InputAt(i))->HasFixedPolicy() || I'd prefer to have the for loops wrapped in #ifdef DEBUG so there's clearly no code in release builds. http://codereview.chromium.org/6069012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
