http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1222 src/arm/lithium-codegen-arm.cc:1222: __ cmp(reg, Operand(Factory::null_value())); ou should use the root array for reading these fixed objects. __ LoadRoot(ip, Heap::kNullValueRootIndex); __ cmp(reg, ip); http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1223 src/arm/lithium-codegen-arm.cc:1223: if (instr->is_strict()) { Two conditional LoadRoot should work here. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1224 src/arm/lithium-codegen-arm.cc:1224: __ mov(result, Operand(Handle<Object>(Heap::true_value()))); Use root array. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1227 src/arm/lithium-codegen-arm.cc:1227: __ mov(result, Operand(Handle<Object>(Heap::false_value()))); Use root array. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1232 src/arm/lithium-codegen-arm.cc:1232: __ cmp(reg, Operand(Factory::undefined_value())); Use root array. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1239 src/arm/lithium-codegen-arm.cc:1239: __ ldr(scratch, FieldMemOperand(reg, HeapObject::kMapOffset)); Code in comment. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1245 src/arm/lithium-codegen-arm.cc:1245: __ mov(result, Operand(Handle<Object>(Heap::false_value()))); Use root array. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1248 src/arm/lithium-codegen-arm.cc:1248: __ mov(result, Operand(Handle<Object>(Heap::true_value()))); Use root array. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode1794 src/arm/lithium-codegen-arm.cc:1794: __ cmp(ToRegister(instr->index()), ToOperand(instr->length())); To much indention. http://codereview.chromium.org/6069010/diff/4001/src/arm/lithium-codegen-arm.cc#newcode2149 src/arm/lithium-codegen-arm.cc:2149: void LCodeGen::DoCheckPrototypeMaps(LCheckPrototypeMaps* instr) { reg -> temp1, temp -> temp2? http://codereview.chromium.org/6069010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
