On 2011/01/04 11:39:19, Søren Gjesse wrote:
This change is really confusing the differ, but you only added the new
outer
condition, indented 4 chars and added the targets v8 and v8_shell in the
else
part, right?
Yes.
However please format this to be inside the 80 char line length.
Done where it was trivial. There are two cases where I don't know what to
do,
see below.
http://codereview.chromium.org/6092006/diff/4001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
http://codereview.chromium.org/6092006/diff/4001/tools/gyp/v8.gyp#newcode262
tools/gyp/v8.gyp:262:
'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
I'm not sure how to wrap this line.
http://codereview.chromium.org/6092006/diff/4001/tools/gyp/v8.gyp#newcode801
tools/gyp/v8.gyp:801: ['v8_target_arch=="arm" and host_arch=="x64" and
_toolset=="host"', {
I'm not sure how to wrap this line.
http://codereview.chromium.org/6092006/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
