LGTM
http://codereview.chromium.org/6092007/diff/19001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/6092007/diff/19001/src/ia32/macro-assembler-ia32.cc#newcode67 src/ia32/macro-assembler-ia32.cc:67: mov(Operand(scratch, 0), addr); some of the addresses that come here can have rogue heap object tag at the end this is usually caused by passing a tagged address and an offset from the untagged address. please document or fix it otherwise we might be surprised during write buffer decoding. http://codereview.chromium.org/6092007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
