r6182 -> r6183 On Wed, Jan 5, 2011 at 15:06, Søren Gjesse <[email protected]> wrote:
> I had to revert this again as it caused test failures, see > http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/343/steps/Check/logs/stdio. > It was reverted in r6182. > > Regards, > Søren > > > On Wed, Jan 5, 2011 at 14:57, <[email protected]> wrote: > >> LGTM >> >> We are not linting the line lengths of the JS files, so I accepted the >> long >> lines in d8.js. >> >> Committed: http://code.google.com/p/v8/source/detail?r=6180 >> >> Thank you for the patch! >> >> It would be nice if you could follow up with some tests of the new debug >> protocol messages like we already have for the current messages in >> test/mjsumit/debug-* >> >> We also need to update http://code.google.com/p/v8/wiki/DebuggerProtocolwith >> information on the new messages and changes to the existing ones. Actually >> you >> will not be able to edit >> http://code.google.com/p/v8/wiki/DebuggerProtocol >> online, but you can send a update and I will put it in. >> >> >> http://codereview.chromium.org/5980006/ >> > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
