Reviewers: Rico, Mads Ager,
Message:
This is a draft of first phase of the fix to bug
http://code.google.com/p/v8/issues/detail?id=981 where first we need to
disable
passing global object through Function.call and apply if thisArg is
null/undefined. Next step will be fixing the actual library functions to
perform
ToObject individually as specified by ES5.
I ran tests on x64, ia32 and arm (simulator) and presubmit.py.
To keep the scope of the change small I didn't go for the full fix to the
bug
981 but plan to do that in future patches.
Please add additional code reviewers in case I didn't identify the optimal
ones.
Thank you!
Martin
Description:
ES5 fix to Function.prototype.call and Function.prototype.apply to
- not wrap values
- not pass global object if thisArg is undefined or null
This is the first step to fixing bug:
http://code.google.com/p/v8/issues/detail?id=981
BUG=
TEST=
Please review this at http://codereview.chromium.org/6087011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/builtins-arm.cc
M src/ia32/builtins-ia32.cc
M src/x64/builtins-x64.cc
M test/mjsunit/apply.js
M test/mjsunit/arguments-apply.js
M test/mjsunit/call.js
M test/mjsunit/compiler/regress-arguments.js
M test/mjsunit/regress/regress-485.js
M test/mjsunit/value-wrapper.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
