Reviewers: Søren Gjesse,
Message:
Søren, here is the test changes needed to ensure that r6180 (debugger
enhancements) do not fail the tests. I will look into adding additional
tests
for the other enhancements later.
Description:
Update debugger test to expect new default break on exceptions settings.
With this patch, the changes for r6180 can now be re-applied without any
test
failures.
Please review this at http://codereview.chromium.org/6086010/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/cctest/test-debug.cc
Index: test/cctest/test-debug.cc
===================================================================
--- test/cctest/test-debug.cc (revision 6187)
+++ test/cctest/test-debug.cc (working copy)
@@ -3712,7 +3712,7 @@
v8::V8::AddMessageListener(MessageCallbackCount);
v8::Debug::SetDebugEventListener(DebugEventCounter);
- // Initial state should be break on uncaught exception.
+ // Initial state should be no break on exceptions.
DebugEventCounterClear();
MessageCallbackCountClear();
caught->Call(env->Global(), 0, NULL);
@@ -3720,8 +3720,8 @@
CHECK_EQ(0, uncaught_exception_hit_count);
CHECK_EQ(0, message_callback_count);
notCaught->Call(env->Global(), 0, NULL);
- CHECK_EQ(1, exception_hit_count);
- CHECK_EQ(1, uncaught_exception_hit_count);
+ CHECK_EQ(0, exception_hit_count);
+ CHECK_EQ(0, uncaught_exception_hit_count);
CHECK_EQ(1, message_callback_count);
// No break on exception
@@ -3841,6 +3841,9 @@
v8::HandleScope scope;
DebugLocalContext env;
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
v8::internal::Top::TraceException(false);
// Create a function for checking the function when hitting a break
point.
@@ -3892,6 +3895,9 @@
v8::HandleScope scope;
DebugLocalContext env;
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
// Create a function for checking the function when hitting a break
point.
frame_function_name = CompileFunction(&env,
frame_function_name_source,
@@ -6523,6 +6529,10 @@
TEST(ExceptionMessageWhenMessageHandlerIsReset) {
v8::HandleScope scope;
DebugLocalContext env;
+
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
exception_event_count = 0;
const char* script = "function f() {throw new Error()};";
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
