Reviewers: Søren Gjesse,
Description:
Fix disassembly comment for CallFunctionStub.
The comment was printing the entire minor key but labeling it with 'argc'.
Please review this at http://codereview.chromium.org/6120001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Affected files:
M src/code-stubs.h
M src/disassembler.cc
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index
dc52083a195d83f085a36de45385e13dee04feea..cc52b26e06210ae17052087958e68fc2b75c2019
100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -723,6 +723,10 @@ class CallFunctionStub: public CodeStub {
void Generate(MacroAssembler* masm);
+ static int ExtractArgcFromMinorKey(int minor_key) {
+ return ArgcBits::decode(minor_key);
+ }
+
private:
int argc_;
InLoopFlag in_loop_;
@@ -754,11 +758,6 @@ class CallFunctionStub: public CodeStub {
bool ReceiverMightBeValue() {
return (flags_ & RECEIVER_MIGHT_BE_VALUE) != 0;
}
-
- public:
- static int ExtractArgcFromMinorKey(int minor_key) {
- return ArgcBits::decode(minor_key);
- }
};
Index: src/disassembler.cc
diff --git a/src/disassembler.cc b/src/disassembler.cc
index
bb0a07229ab7e5f03e43e61eae9109243ec3d78a..194a299f020fa99530cd8abb5e1d6824088ec685
100644
--- a/src/disassembler.cc
+++ b/src/disassembler.cc
@@ -1,4 +1,4 @@
-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -268,10 +268,13 @@ static int DecodeIt(FILE* f,
Code::Kind2String(kind),
CodeStub::MajorName(major_key, false));
switch (major_key) {
- case CodeStub::CallFunction:
- out.AddFormatted("argc = %d", minor_key);
+ case CodeStub::CallFunction: {
+ int argc =
+ CallFunctionStub::ExtractArgcFromMinorKey(minor_key);
+ out.AddFormatted("argc = %d", argc);
break;
- default:
+ }
+ default:
out.AddFormatted("minor: %d", minor_key);
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
