Revision: 6208 Author: [email protected] Date: Thu Jan 6 06:13:40 2011 Log: Fix disassembly comment for CallFunctionStub.
The comment was printing the entire minor key but labeling it with 'argc'. Review URL: http://codereview.chromium.org/6120001 http://code.google.com/p/v8/source/detail?r=6208 Modified: /branches/bleeding_edge/src/code-stubs.h /branches/bleeding_edge/src/disassembler.cc ======================================= --- /branches/bleeding_edge/src/code-stubs.h Wed Jan 5 03:17:37 2011 +++ /branches/bleeding_edge/src/code-stubs.h Thu Jan 6 06:13:40 2011 @@ -1,4 +1,4 @@ -// Copyright 2006-2008 the V8 project authors. All rights reserved. +// Copyright 2011 the V8 project authors. All rights reserved. // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are // met: @@ -723,6 +723,10 @@ void Generate(MacroAssembler* masm); + static int ExtractArgcFromMinorKey(int minor_key) { + return ArgcBits::decode(minor_key); + } + private: int argc_; InLoopFlag in_loop_; @@ -754,11 +758,6 @@ bool ReceiverMightBeValue() { return (flags_ & RECEIVER_MIGHT_BE_VALUE) != 0; } - - public: - static int ExtractArgcFromMinorKey(int minor_key) { - return ArgcBits::decode(minor_key); - } }; ======================================= --- /branches/bleeding_edge/src/disassembler.cc Tue Dec 7 03:31:57 2010 +++ /branches/bleeding_edge/src/disassembler.cc Thu Jan 6 06:13:40 2011 @@ -1,4 +1,4 @@ -// Copyright 2010 the V8 project authors. All rights reserved. +// Copyright 2011 the V8 project authors. All rights reserved. // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are // met: @@ -268,10 +268,13 @@ Code::Kind2String(kind), CodeStub::MajorName(major_key, false)); switch (major_key) { - case CodeStub::CallFunction: - out.AddFormatted("argc = %d", minor_key); + case CodeStub::CallFunction: { + int argc = + CallFunctionStub::ExtractArgcFromMinorKey(minor_key); + out.AddFormatted("argc = %d", argc); break; - default: + } + default: out.AddFormatted("minor: %d", minor_key); } } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
