Reviewers: Lasse Reichstein,
Description:
X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test
expectations.
Please review this at http://codereview.chromium.org/6118002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/lithium-x64.h
M test/mjsunit/mjsunit.status
Index: src/x64/lithium-x64.h
===================================================================
--- src/x64/lithium-x64.h (revision 6213)
+++ src/x64/lithium-x64.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -30,6 +30,7 @@
#include "hydrogen.h"
#include "lithium-allocator.h"
+#include "lithium.h"
#include "safepoint-table.h"
namespace v8 {
@@ -45,6 +46,9 @@
LInstruction() { }
virtual ~LInstruction() { }
+ virtual void PrintTo(StringStream* stream) const { UNIMPLEMENTED(); }
+ virtual void PrintDataTo(StringStream* stream) const { }
+
// Predicates should be generated by macro as in lithium-ia32.h.
virtual bool IsLabel() const {
UNIMPLEMENTED();
@@ -55,18 +59,31 @@
return false;
}
- LPointerMap* pointer_map() const {
- UNIMPLEMENTED();
- return NULL;
- }
+ void set_environment(LEnvironment* env) { environment_.set(env); }
+ LEnvironment* environment() const { return environment_.get(); }
+ bool HasEnvironment() const { return environment_.is_set(); }
- bool HasPointerMap() const {
- UNIMPLEMENTED();
- return false;
+ void set_pointer_map(LPointerMap* p) { pointer_map_.set(p); }
+ LPointerMap* pointer_map() const { return pointer_map_.get(); }
+ bool HasPointerMap() const { return pointer_map_.is_set(); }
+
+ void set_result(LOperand* operand) { result_.set(operand); }
+ LOperand* result() const { return result_.get(); }
+ bool HasResult() const { return result_.is_set(); }
+
+ void set_hydrogen_value(HValue* value) { hydrogen_value_ = value; }
+ HValue* hydrogen_value() const { return hydrogen_value_; }
+
+ void set_deoptimization_environment(LEnvironment* env) {
+ deoptimization_environment_.set(env);
}
+ LEnvironment* deoptimization_environment() const {
+ return deoptimization_environment_.get();
+ }
+ bool HasDeoptimizationEnvironment() const {
+ return deoptimization_environment_.is_set();
+ }
- virtual void PrintTo(StringStream* stream) const { UNIMPLEMENTED(); }
-
private:
SetOncePointer<LEnvironment> environment_;
SetOncePointer<LPointerMap> pointer_map_;
Index: test/mjsunit/mjsunit.status
===================================================================
--- test/mjsunit/mjsunit.status (revision 6213)
+++ test/mjsunit/mjsunit.status (working copy)
@@ -109,11 +109,18 @@
##############################################################################
[ $arch == arm && $crankshaft ]
-# Test that currently fail with crankshaft on ARM.
+# Test that currently fails with crankshaft on ARM.
compiler/simple-osr: FAIL
##############################################################################
+[ $arch == x64 && $crankshaft ]
+
+# Test that currently fails with crankshaft on X64.
+compiler/simple-osr: FAIL
+
+
+##############################################################################
[ $arch == mips ]
# Skip all tests on MIPS.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
