Reviewers: fschneider,
Description:
Move IsArgumentsMarker from class MaybeObject to Object.
Since we never need to ask it of a MaybeObject, put it with the other
oddball testers in class Object for consistency.
Please review this at http://codereview.chromium.org/6138004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Affected files:
M src/objects-inl.h
M src/objects.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
f4233e2d31c5853b7943470c2646ae2a732a1feb..3c9dc82351f1ba57a72e9e6c44fffbf5bde92b3d
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -423,11 +423,6 @@ bool MaybeObject::IsTheHole() {
}
-bool MaybeObject::IsArgumentsMarker() {
- return this == Heap::arguments_marker();
-}
-
-
Failure* Failure::cast(MaybeObject* obj) {
ASSERT(HAS_FAILURE_TAG(obj));
return reinterpret_cast<Failure*>(obj);
@@ -735,6 +730,11 @@ bool Object::IsFalse() {
}
+bool Object::IsArgumentsMarker() {
+ return this == Heap::arguments_marker();
+}
+
+
double Object::Number() {
ASSERT(IsNumber());
return IsSmi()
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
8d3d2be03ebc233203286e0590fee5c8fc81191b..063555e03d6212967cba92f137ef76915930666a
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -593,7 +593,6 @@ class MaybeObject BASE_EMBEDDED {
inline bool IsOutOfMemory();
inline bool IsException();
INLINE(bool IsTheHole());
- INLINE(bool IsArgumentsMarker());
inline bool ToObject(Object** obj) {
if (IsFailure()) return false;
*obj = reinterpret_cast<Object*>(this);
@@ -710,6 +709,7 @@ class Object : public MaybeObject {
INLINE(bool IsNull());
INLINE(bool IsTrue());
INLINE(bool IsFalse());
+ inline bool IsArgumentsMarker();
// Extract the number.
inline double Number();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
