Hi Peter,
I will land this for you with the nit (since you do not have commit rights).
Lets put the additional tests in another patch and get this in now. Thanks
a lot
for the effort.
Cheers,
Rico
On 2011/01/07 09:47:30, Rico wrote:
LGTM
I had not considered the possibility of being able to change writable to
false
even with configurable set to false. I saw the discussion on es-discuss
and
that
is a somehow valid point (although it intuitively does not make a lot of
sense).
But we should of course follow the spec here.
http://codereview.chromium.org/6035014/diff/10001/src/v8natives.js
File src/v8natives.js (right):
http://codereview.chromium.org/6035014/diff/10001/src/v8natives.js#newcode645
src/v8natives.js:645: // Step 12 - updating an existing accessor property
with
generic
with generic -> with a generic
http://codereview.chromium.org/6035014/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
