lgtm
http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py File tools/gc-nvp-trace-processor.py (right): http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py#newcode307 tools/gc-nvp-trace-processor.py:307: suffixes = ['B', 'KB', 'MB', 'GB'] K -> k I also prefer bytes to B since B is a measure of volume but that may look messy in the output? http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py#newcode322 tools/gc-nvp-trace-processor.py:322: HumanReadable(total_live_after / total_gc))) Should we check for total_gc being zero? http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py#newcode344 tools/gc-nvp-trace-processor.py:344: throughput('MS', marksweeps) This seems excessively concise. http://codereview.chromium.org/6220001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
