New version uploaded.
Rodolph: Please look at the changes in code-stubs-arm.cc - didn't we miss
the
clearing of the cumulative exception flags when testing for NaNs before
(condition vs)?
http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode585
src/arm/macro-assembler-arm.h:585: void VFPCompareAndSetFlags(const
DwVfpRegister src1,
On 2011/01/10 11:24:10, Rodolph Perfetta wrote:
Since the instruction sets the flags, the s parameter is meaningless.
In fact
the s parameter in the vcmp instruction is also superfluous and
probably should
be removed, it is not present in the instruction encoding.
Done.
http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode590
src/arm/macro-assembler-arm.h:590: vmrs(pc);
On 2011/01/10 11:24:10, Rodolph Perfetta wrote:
vmrs should be conditional too.
Done.
http://codereview.chromium.org/6117003/diff/7001/src/arm/macro-assembler-arm.h#newcode592
src/arm/macro-assembler-arm.h:592: void VFPCompareAndSetFlags(const
DwVfpRegister src1,
On 2011/01/10 11:24:10, Rodolph Perfetta wrote:
As above.
Done.
http://codereview.chromium.org/6117003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
