LGTM. I like to have precondition asserts all together at the start.
http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc#newcode1695 src/arm/lithium-arm.cc:1695: ASSERT(instr->key()->representation().IsInteger32()); Put this precondition assert right after the other one? http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h#newcode1246 src/arm/lithium-arm.h:1246: LOperand* key) The line break between the arguments is no longer necessary? http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc#newcode1708 src/ia32/lithium-ia32.cc:1708: ASSERT(instr->key()->representation().IsInteger32()); Move this assert up by the other one? http://codereview.chromium.org/6158004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
