LGTM
http://codereview.chromium.org/6164003/diff/5001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6164003/diff/5001/src/arm/lithium-codegen-arm.cc#newcode1741 src/arm/lithium-codegen-arm.cc:1741: __ mov(receiver, length); Please add a comment why we are adding 4 here, and use kPointerSize instead of 4. http://codereview.chromium.org/6164003/diff/5001/src/arm/lithium-codegen-arm.cc#newcode1746 src/arm/lithium-codegen-arm.cc:1746: Label loop; I don't know if it will make a difference, but we have 4 free registers, so we could use load/store multiple with 4 elements at the time after aligning length by 0-3 initial load/stores by checking the two lower bit s of length. http://codereview.chromium.org/6164003/diff/5001/src/arm/lithium-codegen-arm.cc#newcode1758 src/arm/lithium-codegen-arm.cc:1758: v8::internal::ParameterCount actual(receiver); Maybe comment here that receiver stores the original count and is r0 which is mandated by InvokeFunction. http://codereview.chromium.org/6164003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
