LGTM with temp2 gone.
http://codereview.chromium.org/6201004/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6201004/diff/1/src/arm/lithium-codegen-arm.cc#newcode1433 src/arm/lithium-codegen-arm.cc:1433: ASSERT(!temp.is(temp2)); // But input and temp2 may be the same register. Can't we get rid of temp2 and just use the scratch register Register scratch = scratch0; Adn then temp2 -> scratch http://codereview.chromium.org/6201004/diff/1/src/arm/lithium-codegen-arm.cc#newcode1505 src/arm/lithium-codegen-arm.cc:1505: Register temp = ToRegister(instr->temporary()); Probably don't need temp2 for the instruction after all, and the the swapping is not needed. http://codereview.chromium.org/6201004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
