Looks good to me
http://codereview.chromium.org/6170001/diff/22001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6170001/diff/22001/src/arm/macro-assembler-arm.cc#newcode1455 src/arm/macro-assembler-arm.cc:1455: const int kNextOffset = 0; Apparently it's not used. Remove it or reference in MemOperand(r7 + kNextOffset) (the last one looks more consistent for me). http://codereview.chromium.org/6170001/diff/22001/src/arm/macro-assembler-arm.cc#newcode1488 src/arm/macro-assembler-arm.cc:1488: ldr(r6, MemOperand(r7, kLevelOffset)); Apparently r6 still contains valid level at this point. If so we could only check int for debugging purposes: if (FLAG_debug_code) { ldr(r1, MemOperand(r7, kLevelOffset)); cmp(r1, r6); Check(eq, ...); } http://codereview.chromium.org/6170001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
