LGTM

http://codereview.chromium.org/6146009/diff/3001/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/6146009/diff/3001/src/messages.js#newcode955
src/messages.js:955: if (m === kAddMessageAccessorsMarker) {
Maybe add a comment that DefineOneShotAccessor ensures that there always
is a 'message' property set directly on the object.

http://codereview.chromium.org/6146009/diff/3001/test/mjsunit/error-constructors.js
File test/mjsunit/error-constructors.js (right):

http://codereview.chromium.org/6146009/diff/3001/test/mjsunit/error-constructors.js#newcode33
test/mjsunit/error-constructors.js:33:
Maybe add a comment here to what this is actually testing.

http://codereview.chromium.org/6146009/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to