LGTM This is a lot of code to review without knowing which part in particular was changed compared to ia32. I would like to take a closer look in kompare tomorrow.
I am also uncertain about the setup of the different methods in lithium-x64, but I guess we need to change this when we actually do the codegen anyway so this is
fine by me for the moment. http://codereview.chromium.org/6201006/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6201006/diff/1/src/x64/lithium-codegen-x64.cc#newcode224 src/x64/lithium-codegen-x64.cc:224: // TODO(twuerthinger): Introduce marker operands to indicate that this value Lets file a bug for this if it needs to be fixed- Thomas probably will not fix this. http://codereview.chromium.org/6201006/diff/1/src/x64/lithium-codegen-x64.cc#newcode557 src/x64/lithium-codegen-x64.cc:557: add line http://codereview.chromium.org/6201006/diff/1/src/x64/lithium-codegen-x64.cc#newcode664 src/x64/lithium-codegen-x64.cc:664: extra blank line http://codereview.chromium.org/6201006/diff/1/src/x64/lithium-codegen-x64.cc#newcode1121 src/x64/lithium-codegen-x64.cc:1121: Abort("Unimplemented: %s", "DoOsrEntry");} Move } to its own line http://codereview.chromium.org/6201006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
