LGTM
http://codereview.chromium.org/6164005/diff/11001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (left): http://codereview.chromium.org/6164005/diff/11001/src/arm/lithium-codegen-arm.cc#oldcode2513 src/arm/lithium-codegen-arm.cc:2513: __ ldr(result, FieldMemOperand(result, JSGlobalPropertyCell::kValueOffset)); Accidental edit? http://codereview.chromium.org/6164005/diff/11001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6164005/diff/11001/src/arm/lithium-codegen-arm.cc#newcode943 src/arm/lithium-codegen-arm.cc:943: __ str(r0, MemOperand(sp, DwVfpRegister::kNumAllocatableRegisters * I think this deserves at least a comment. On http://codereview.chromium.org/6248004 from I made the following comment on almost the same construct n IA32 we have EspIndexForPushAll, and I think we need something like that here, maybe a macro assembler instruction like StoreToSafePointRegister to work in correspondance with PushSafepointRegisters/PopSafepointRegisters. http://codereview.chromium.org/6164005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
