Thanks a lot for review, Lasse. Submitting.
http://codereview.chromium.org/6119009/diff/6001/include/v8.h File include/v8.h (right): http://codereview.chromium.org/6119009/diff/6001/include/v8.h#newcode3356 include/v8.h:3356: template <size_t ptr_size> struct SmiTraits; On 2011/01/13 12:57:57, Lasse Reichstein wrote:
I think I would prefer "SmiTagging", but it's better than
SmiConstants. Done. http://codereview.chromium.org/6119009/diff/6001/include/v8.h#newcode3386 include/v8.h:3386: // alignment. Currently we require 8 bytes alignment (which On 2011/01/13 12:57:57, Lasse Reichstein wrote:
Drop "better" alignment (the text should be stand-alone, so it should
not be
implicitly relative to the 32-bit case). Just say something like "To maximize the range of pointers that can be
encoded
in the available 32 bit, we require them to be 8-byte aligned".
Done. http://codereview.chromium.org/6119009/diff/6001/include/v8.h#newcode3393 include/v8.h:3393: intptr_t(0xffffffff) << kPointerAlignment; On 2011/01/13 12:57:57, Lasse Reichstein wrote:
Shouldn't this be inverted to mask the bits that must be zero?
Thanks a lot, of course it should. http://codereview.chromium.org/6119009/diff/6001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6119009/diff/6001/test/cctest/test-api.cc#newcode829 test/cctest/test-api.cc:829: *value = 42; On 2011/01/13 12:57:57, Lasse Reichstein wrote:
Try storing both values that can and can't be stored as smis.
Done. http://codereview.chromium.org/6119009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
