I'm a little concerned about this. (I just glanced at this, so maybe I'm missing something about the approach.)
We already have inlining of JS functions, and we have %_ functions that get expanded inline into assembly code. Couldn't you achieve much the same thing by implementing %_StringCharCodeAt and ensuring that StringCharCodeAt is able to be hit by inlining? On Thu, Jan 13, 2011 at 3:18 PM, <[email protected]> wrote: > Reviewers: fschneider, > > Description: > Support StringCharCodeAt in hydrogen/lithium. > > Please review this at http://codereview.chromium.org/6304001/ > > Affected files: > M src/ast.cc > M src/hydrogen-instructions.h > M src/hydrogen.h > M src/hydrogen.cc > M src/ia32/lithium-codegen-ia32.h > M src/ia32/lithium-codegen-ia32.cc > M src/ia32/lithium-ia32.h > M src/ia32/lithium-ia32.cc > M src/objects-printer.cc > M src/objects.h > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
