LGTM.
http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-codegen-x64.cc#newcode503 src/x64/lithium-codegen-x64.cc:503: __ Move(ToRegister(instr->result()), instr->value()); Good, this handles smi constants efficiently, in the Move instruction. http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6247005/diff/4002/src/x64/lithium-x64.cc#newcode1210 src/x64/lithium-x64.cc:1210: Abort("unsupported constant of type double"); Why does this say "of type double"? http://codereview.chromium.org/6247005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
