LGTM
http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc#newcode318 src/x64/lithium-x64.cc:318: return LStackSlot::Create(index); I would probably make this a if - else statement or change the ia32 to look like this (so that we keep the diff minimal) http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode121 src/x64/lithium-codegen-x64.cc:121: #ifdef _MSC_VER We might need to do this on ia32 as well? http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode125 src/x64/lithium-codegen-x64.cc:125: for (int offset = slots * kPointerSize - 4 * KB; Do we have a kPageSize constant somewhere? http://codereview.chromium.org/6326003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
