http://codereview.chromium.org/6315004/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/6315004/diff/1/src/ia32/stub-cache-ia32.cc#newcode3574 src/ia32/stub-cache-ia32.cc:3574: __ pop(ecx); Why are SSE3 features used on ia32, but not on x64? I see that the int32 case uses cvttsd2siq on x64, but on the other cases, if cvttsd2si is best on x64, why isn't it best on ia32. http://codereview.chromium.org/6315004/diff/1/src/ia32/stub-cache-ia32.cc#newcode3650 src/ia32/stub-cache-ia32.cc:3650: Label not_infinity; I don't see why numbers outside the 32-bit int range are not returning MIN_INT, which is then not screened out by this test. So finite large numbers will return MIN_INT, but on x64, they will return MIN_INT64 or large numbers mod 2^32. Isn't this a difference between platforms? What does the spec say. http://codereview.chromium.org/6315004/diff/1/src/x64/assembler-x64.cc File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/6315004/diff/1/src/x64/assembler-x64.cc#newcode2723 src/x64/assembler-x64.cc:2723: disasm-x64.cc has an assert on line 1117 that will now fail. It needs to be changed, to look like the way disasm-x6 handles cvttsd2si. http://codereview.chromium.org/6315004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
