Revision: 6338
Author: [email protected]
Date: Sun Jan 16 23:03:19 2011
Log: Relax verification of JSFunction result caches.
As invocation of a functin may trigger GC and hence clear all the caches,
it's hard to ensure previous invariants.
Current invariant is both a key and a value should be the holes or not
holes.
Review URL: http://codereview.chromium.org/6309004
http://code.google.com/p/v8/source/detail?r=6338
Modified:
/branches/bleeding_edge/src/objects-debug.cc
=======================================
--- /branches/bleeding_edge/src/objects-debug.cc Thu Jan 6 07:53:56 2011
+++ /branches/bleeding_edge/src/objects-debug.cc Sun Jan 16 23:03:19 2011
@@ -674,13 +674,12 @@
ASSERT_EQ(0, finger % kEntrySize);
if (FLAG_enable_slow_asserts) {
- for (int i = kEntriesIndex; i < size; i++) {
- ASSERT(!get(i)->IsTheHole());
+ STATIC_ASSERT(2 == kEntrySize);
+ for (int i = kEntriesIndex; i < length(); i += kEntrySize) {
get(i)->Verify();
- }
- for (int i = size; i < length(); i++) {
- ASSERT(get(i)->IsTheHole());
- get(i)->Verify();
+ get(i + 1)->Verify();
+ // Key and value must be either both the holes, or not.
+ ASSERT(get(i)->IsTheHole() == get(i + 1)->IsTheHole());
}
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
