LGTM
http://codereview.chromium.org/6355006/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6355006/diff/1/src/parser.cc#newcode795 src/parser.cc:795: source_location.beg_pos, source_location.end_pos); I find one argument per line more readable. http://codereview.chromium.org/6355006/diff/1/test/mjsunit/delay-syntax-error.js File test/mjsunit/delay-syntax-error.js (right): http://codereview.chromium.org/6355006/diff/1/test/mjsunit/delay-syntax-error.js#newcode30 test/mjsunit/delay-syntax-error.js:30: // CHANGED in Jan. 2011. JSC switched to reporting these syntax errors Let's just update the description with the current behavior instead of keeping a change log? http://codereview.chromium.org/6355006/diff/1/test/mjsunit/delay-syntax-error.js#newcode36 test/mjsunit/delay-syntax-error.js:36: // Do throw syntax errors for illegal break and continue at compile time. Do throw -> Throw http://codereview.chromium.org/6355006/diff/1/test/mjsunit/regress/regress-990205.js File test/mjsunit/regress/regress-990205.js (right): http://codereview.chromium.org/6355006/diff/1/test/mjsunit/regress/regress-990205.js#newcode28 test/mjsunit/regress/regress-990205.js:28: // We not throw syntax errors early for invalid break and continue We not -> We http://codereview.chromium.org/6355006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
