LGTM and thanks!

-- Vitaly


http://codereview.chromium.org/6348002/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6348002/diff/1/src/runtime.cc#newcode10657
src/runtime.cc:10657: MUST_USE_RESULT static MaybeObject*
CacheMiss(FixedArray* cache_obj,
The name is probably too generic for this >10K line file.

http://codereview.chromium.org/6348002/diff/1/src/runtime.cc#newcode10685
src/runtime.cc:10685: // Function invocation can have cleared the cache.
 Reread all the data.
nit: "may have" or "might have". "Can have" sounds more like could do,
but didn't.

http://codereview.chromium.org/6348002/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to