Reviewers: Søren Gjesse, Karl Klose, Description: ARM: Reenable Div and Mod in the ARM lithium codegenerator. The crashes uncovered by this were caused by constant pool in safe-point tables. This should be safe to enable now.
Please review this at http://codereview.chromium.org/6243005/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/lithium-codegen-arm.cc M src/frames.cc Index: src/arm/lithium-codegen-arm.cc =================================================================== --- src/arm/lithium-codegen-arm.cc (revision 6347) +++ src/arm/lithium-codegen-arm.cc (working copy) @@ -1004,7 +1004,6 @@ void LCodeGen::DoModI(LModI* instr) { - Abort("ModI not implemented"); class DeferredModI: public LDeferredCode { public: DeferredModI(LCodeGen* codegen, LModI* instr) @@ -1060,7 +1059,6 @@ void LCodeGen::DoDivI(LDivI* instr) { - Abort("DivI not implemented"); class DeferredDivI: public LDeferredCode { public: DeferredDivI(LCodeGen* codegen, LDivI* instr) Index: src/frames.cc =================================================================== --- src/frames.cc (revision 6346) +++ src/frames.cc (working copy) @@ -554,6 +554,7 @@ parameters_base += safepoint_entry.argument_count(); } + // Skip saved double registers. if (safepoint_entry.has_doubles()) { parameters_base += DoubleRegister::kNumAllocatableRegisters * kDoubleSize / kPointerSize; -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
