Revision: 6348
Author: [email protected]
Date: Mon Jan 17 04:52:06 2011
Log: ARM: Reenable Div and Mod in the ARM lithium codegenerator. The
crashes uncovered by this were caused by constant pool in safe-point
tables. This should be safe to enable now.

Review URL: http://codereview.chromium.org/6243005
http://code.google.com/p/v8/source/detail?r=6348

Modified:
 /branches/bleeding_edge/src/arm/lithium-codegen-arm.cc
 /branches/bleeding_edge/src/frames.cc

=======================================
--- /branches/bleeding_edge/src/arm/lithium-codegen-arm.cc Mon Jan 17 04:45:39 2011 +++ /branches/bleeding_edge/src/arm/lithium-codegen-arm.cc Mon Jan 17 04:52:06 2011
@@ -1004,7 +1004,6 @@


 void LCodeGen::DoModI(LModI* instr) {
-  Abort("ModI not implemented");
   class DeferredModI: public LDeferredCode {
    public:
     DeferredModI(LCodeGen* codegen, LModI* instr)
@@ -1060,7 +1059,6 @@


 void LCodeGen::DoDivI(LDivI* instr) {
-  Abort("DivI not implemented");
   class DeferredDivI: public LDeferredCode {
    public:
     DeferredDivI(LCodeGen* codegen, LDivI* instr)
=======================================
--- /branches/bleeding_edge/src/frames.cc       Fri Jan 14 07:24:41 2011
+++ /branches/bleeding_edge/src/frames.cc       Mon Jan 17 04:52:06 2011
@@ -554,6 +554,7 @@
     parameters_base += safepoint_entry.argument_count();
   }

+  // Skip saved double registers.
   if (safepoint_entry.has_doubles()) {
     parameters_base += DoubleRegister::kNumAllocatableRegisters *
         kDoubleSize / kPointerSize;

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to