This patch confuses me. You went back to one miss stub that takes just two arguments. However, in the runtime system you still check for the additional argument. Am I missing something?
http://codereview.chromium.org/6344005/diff/6001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/6344005/diff/6001/src/ia32/stub-cache-ia32.cc#newcode1367 src/ia32/stub-cache-ia32.cc:1367: extra_ic_state_); Why do you need the extra_ic_state_ here? One miss stub per kind should be enough? http://codereview.chromium.org/6344005/diff/6001/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/6344005/diff/6001/src/ic.cc#newcode657 src/ic.cc:657: if (kind_ == Code::CALL_IC && state == MONOMORPHIC) { Why isn't this just part of the normal MONOMORPHIC branch? http://codereview.chromium.org/6344005/diff/6001/src/ic.cc#newcode1719 src/ic.cc:1719: ASSERT(args.length() == 2 || args.length() == 3); Why do you need to pass the extra state to the miss call at all? We should have enough info to figure this out in the runtime system. Is this a left over from the previous change? http://codereview.chromium.org/6344005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
