I don't see the value of X64 kPointerToSmiShift, but couldn't it be 16, since the top 16 (or 17?) bits of a 64-bit address agree. Then any 64kb aligned value would be representable. But maybe this doesn't matter for your use case.
On Wed, Jan 19, 2011 at 11:19 AM, <[email protected]> wrote: > LGTM > > > http://codereview.chromium.org/6242005/diff/1/include/v8.h > File include/v8.h (right): > > http://codereview.chromium.org/6242005/diff/1/include/v8.h#newcode3391 > include/v8.h:3391: ~(intptr_t(0xffffffff) << kPointerAlignment); > intptr_t => uintptr_t > > http://codereview.chromium.org/6242005/diff/1/include/v8.h#newcode3460 > include/v8.h:3460: const uintptr_t address = > > reinterpret_cast<intptr_t>(value); > <intptr_t> => <uintptr_t> > > http://codereview.chromium.org/6242005/diff/1/src/api.cc > File src/api.cc (right): > > http://codereview.chromium.org/6242005/diff/1/src/api.cc#newcode3270 > src/api.cc:3270: const uintptr_t address = > > reinterpret_cast<intptr_t>(ptr); > <intptr_t> => <uintptr_t> > > http://codereview.chromium.org/6242005/diff/1/src/api.cc#newcode3277 > src/api.cc:3277: const uintptr_t address = > > reinterpret_cast<intptr_t>(ptr); > <intptr_t> => <uintptr_t> > > > http://codereview.chromium.org/6242005/ > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
