No, that should not have worked, but it seems that Visual Studio have some strncpy_s overloads behind its back. I changed it to use the OS::StrNCpy in http://code.google.com/p/v8/source/detail?r=6382. Thanks for letting us know.
Regards, Søren On Mon, Jan 17, 2011 at 21:04, <[email protected]> wrote: > Does this actually work on msvc? > On mingw it certainly doesn't because strncpy_s takes 4 arguments, not 3. > I think it should be strncpy_s(name_, sizeof(name_), name, strlen(name)) > > > http://codereview.chromium.org/6056006/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
