http://codereview.chromium.org/6243008/diff/3001/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6243008/diff/3001/src/hydrogen.cc#newcode4156 src/hydrogen.cc:4156: if (!expr->target()->shared()->HasBuiltinFunctionId()) return false; On 2011/01/19 16:23:44, fschneider wrote:
Maybe we don't need IsBuiltinMathFunction() anymore and can get rid of
it. Done. http://codereview.chromium.org/6243008/diff/3001/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/6243008/diff/3001/src/ia32/lithium-ia32.h#newcode1612 src/ia32/lithium-ia32.h:1612: class LStringLength: public LTemplateInstruction<1, 1> { On 2011/01/19 16:23:44, fschneider wrote:
For consistency I'd write
public LTemplateInstruction<1, 1, 0>
(Probably I should remove the default T=0 template parameter for the
number of
temps.)
Done. http://codereview.chromium.org/6243008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
