LGTM
http://codereview.chromium.org/6347007/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/6347007/diff/1/src/arm/assembler-arm.h#newcode377 src/arm/assembler-arm.h:377: inline int SpIndexForPushAll(Register reg) { We have SafepointRegisterSlot in macro assembler which returns a MemOperand. I think we should stick to that, so that "Safepoint" is part of the name instead of "PushAll" which is inherited from IA32. http://codereview.chromium.org/6347007/diff/11001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6347007/diff/11001/src/arm/lithium-codegen-arm.cc#newcode2479 src/arm/lithium-codegen-arm.cc:2479: __ jmp(&done); Can't you move the PushSafepointRegisters() to here and don't Push/Pop for positive numbers? That is jump to the exit_label() if positive? http://codereview.chromium.org/6347007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
