LGTM
http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc#newcode2849 src/arm/lithium-codegen-arm.cc:2849: if (index.is_valid()) { Checking instr->index()->IsConstantOperand() instead of index.is_valid() seems more clear. http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc#newcode2864 src/arm/lithium-codegen-arm.cc:2864: if (index.is_valid()) { Ditto. http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2713 src/ia32/lithium-codegen-ia32.cc:2713: if (index.is_valid()) { instr->index()->IsConstantOperand()? http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2728 src/ia32/lithium-codegen-ia32.cc:2728: if (index.is_valid()) { Ditto. http://codereview.chromium.org/6368009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
