On 2011/01/20 14:41:23, Erik Corry wrote:
This needs tests in our own v8/test directory that test rounding,
infinities,
NaNs, large numbers.
I will be happy to add more tests for out of range values in a follow-on
CL, but
I am looking for an LGTM on this CL as is. The previous version which fixed
the
x86 and x64 code paths was already LGTM'd.
Is it really right that writing 1e100 to a signed byte array will write
-128
while Infinity will write 0? Any clarification from the standards
committee
on
this?
I am pretty sure this is the behavior defined by the combination of the Web
IDL
and ECMA-262 specifications.
Also it really needs to work on non-SSE2 machines. It's OK to just call
the
runtime in this case, it just has to work. x64 always has SSE2.
I've filed a follow-on bug already about fixing this case.
http://code.google.com/p/v8/issues/detail?id=1056
http://codereview.chromium.org/6303012/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/6303012/diff/1/src/arm/stub-cache-arm.cc#newcode3866
src/arm/stub-cache-arm.cc:3866: // If exponent is too big than result is
minimal
value.
than -> then
I'll fix this preexisting typo upon landing.
http://codereview.chromium.org/6303012/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
