Reviewers: Erik Corry,

Description:
GDBJIT: do not register NULL lineinfo when gdbjit integration is disabled.

Please review this at http://codereview.chromium.org/6255008/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/codegen.cc
  M src/full-codegen.cc


Index: src/codegen.cc
diff --git a/src/codegen.cc b/src/codegen.cc
index c7e6f1c83f4a18533d915d3ae99ca59f72eaea35..f9a2453a09559b7ec5a2c2c32840606ae48718c8 100644
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -267,7 +267,7 @@ bool CodeGenerator::MakeCode(CompilationInfo* info) {
   CodeGenerator::PrintCode(code, info);
   info->SetCode(code);  // May be an empty handle.
 #ifdef ENABLE_GDB_JIT_INTERFACE
-  if (!code.is_null()) {
+  if (FLAG_gdbjit && !code.is_null()) {
     GDBJITLineInfo* lineinfo =
         masm.positions_recorder()->DetachGDBJITLineInfo();

Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index 9366e427a15598888cff7b1f4609e3527f1c9c83..af3ac00bae991ea2b18b33f1638214a03a2e9aa1 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -308,7 +308,7 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {
   CodeGenerator::PrintCode(code, info);
   info->SetCode(code);  // may be an empty handle.
 #ifdef ENABLE_GDB_JIT_INTERFACE
-  if (!code.is_null()) {
+  if (FLAG_gdbjit && !code.is_null()) {
     GDBJITLineInfo* lineinfo =
         masm.positions_recorder()->DetachGDBJITLineInfo();



--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to