Reviewers: Mads Ager,

Description:
WebKit build needs to be told where to look for ICU package.
Chromium already sets this variable in common.gypi which is force included to
all gyp files in the build.


Please review this at http://codereview.chromium.org/6250025/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/extensions/experimental/experimental.gyp


Index: src/extensions/experimental/experimental.gyp
===================================================================
--- src/extensions/experimental/experimental.gyp        (revision 6430)
+++ src/extensions/experimental/experimental.gyp        (working copy)
@@ -27,7 +27,10 @@

 {
   'variables': {
-    'icu_src_dir%': '',
+    # TODO(cira): Find out how to pass this value for arbitrary embedder.
+ # Chromium sets it in common.gypi and does force include of that file for
+    # all sub projects.
+    'icu_src_dir%': '../../../../third_party/icu',
   },
   'targets': [
     {


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to